Tian/role filter #71
Merged
Tian/role filter #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boggers ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have completely changed how the semester filter works where the old implementation works as the following:
Fetch all users from the server -> Combine potential semester and year lists gathered from the data and put it in the filter -> Apply the filter
While URL query method applies a filter at API while we fetch data from the server, which is not compatible with the old method. In addition to that the old implementation was constructed based on the assumption that there is only one filter, as a result, I am unable to add a new filter using the old implementation. Therefore, I have changed the semester filter into the query parameter method and applied the filter at the backend API. However, due to this change, we now do need to keep updating the list of potential semesters in .../server/utils/fields.js
How to Test
Go to the admin dashboard after login. Select fields from the dropdown and check that the correct data is filtered and displayed when applying filter such as developer or senior dev.